Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(labeler): Disable sync-labels that removes labels and pin action #3495

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Mar 13, 2024

When this workflow was introduced, I suggested we try using the sync-labels option, that removes labels if files that were previously matching filters aren't matching anymore, like when some changes are reverted. We would have the time to refine our label-matching rules after merging. After a couple months of using this action (since end of December/beginning of January), I didn't see as much of pull requests where files were initially changed and were finally reverted and that it would have changed the labels of the PR. However, I saw multiple times PRs where manually added labels were removed, sometimes multiple times after each commit, which is a bit less intuitive. Each time I saw labels removed, I tried to think if an adjustment to the label matching patterns would do the trick, but most often not. A recent example is with the recent @HuidaeCho's PRs: a GUI and raster specific bug that needs to be fixed in files that match another section, like display.

So, for the time being, I suggest to turn that option back off, its default value. I left the line there set to false instead of removing it as a reminder that we tried it, in case the default changes in the future. (If in the future the behaviour is more adapted, we could try it again).

It is now our job (us PR reviewers) to remove unnecessary labels if less files are changed in a PR than it has previously had when the labeler workflow ran.

@echoix echoix added this to the 8.4.0 milestone Mar 13, 2024
@github-actions github-actions bot added the CI Continuous integration label Mar 13, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Fine tuning is left to humans. If there is a left over label from a originally intended change, that might be even desired.

@echoix echoix merged commit e3603c9 into main Mar 13, 2024
32 checks passed
@echoix echoix deleted the echoix-patch-2 branch March 13, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants