Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update alpine Docker tag to v3.19 #3293

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
alpine final minor 3.18 -> 3.19

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the use cases of users of the Docker images? If they simply use it inside the container, I don't see how it would impact them if they go and pull a newer beta image.

If they copy out the compiled binaries outside of the container, then for sure some things change, and the way for them to keep having a stable image is to pin it and update when they need.

So, I approve that it should go through.

@neteler neteler added this to the 8.4.0 milestone Dec 22, 2023
@neteler
Copy link
Member

neteler commented Dec 22, 2023

There are other docker images which depend on this one, e.g.

mundialis/esa-snap#25

but I guess we can only move forward here...

@echoix
Copy link
Member

echoix commented Dec 22, 2023

Okay then! I consider downstream repos uses like this kinda out of scope of grass to maintain, and if it were to be critical, the downstream user would have pinned their image, and raised an issue if the state no longer suits them.

@echoix echoix merged commit 00b4a9e into main Dec 22, 2023
19 checks passed
@renovate renovate bot deleted the renovate/alpine-3.x branch December 22, 2023 22:10
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants