-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix pre-commit warnings/errors in linting #3246
Conversation
If there are no objections I'll take the liberty to merge this "whitespace" fix. |
echo "::warning file=.github/workflows/python-code-quality.yml,line=116,col=42,endColumn=48::\ | ||
Temporarily downgraded pytest-pylint to allow merging other PRs. The errors reported\ | ||
with a newer version seem legitimite and should be fixed (2023-10-18,\ | ||
see https://github.com/OSGeo/grass/pull/3205)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It breaks the output of the warning, but that warning was written by me to intentionally mentioning that the test failures must be fixed one day to upgrade the package version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can stay as is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any deciding powers, but I still approve these changes :)
The warning is there:
with colours and all. |
It is the extra spaces in between some words that come from the new indentation. But either way, the goal is to have it removed some day, so it doesn't matter at all. |
Yes, there is one extra space after warning. But the warning is issued correctly. Multiline strings in yaml is a PITA. |
I will update this after #3254 is merged. |
343c16f
to
dbdc6df
Compare
Address pre-commit warnings and fixes. A majority of the issues originate from CI bot PRs, but not all.
This emphasises the need to explore the introduction of pre-commit.ci.