contributing: Expand instructions on pre-commit #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Jun 4, 2023
veroandreo
changed the title
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
veroandreo
approved these changes
Jun 5, 2023
wenzeslaus
approved these changes
Jun 5, 2023
wenzeslaus
changed the title
wenzeslaus
changed the title
wenzeslaus
changed the title
|
I had a look at the unit test failing: |
neteler
approved these changes
Jun 8, 2023
wenzeslaus
approved these changes
Jun 10, 2023
|
@veroandreo Looks like every check and request are taken care of. Would you consider merging this PR? |
neteler
pushed a commit
that referenced
this pull request
Aug 16, 2023
* contributing: Expands instructions on Pre-commit * contributing: Corrects character case in various nouns * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> --------- Co-authored-by: Veronica Andreo <[email protected]>
landam
pushed a commit
to landam/grass
that referenced
this pull request
Oct 25, 2023
* contributing: Expands instructions on Pre-commit * contributing: Corrects character case in various nouns * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> --------- Co-authored-by: Veronica Andreo <[email protected]>
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* contributing: Expands instructions on Pre-commit * contributing: Corrects character case in various nouns * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> * Update doc/development/submitting/submitting.md Co-authored-by: Veronica Andreo <[email protected]> --------- Co-authored-by: Veronica Andreo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more detail on how to use set up Pre-commit.