wxGUI: exception in thread when switching to mapset #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
reviewed
Jun 3, 2023
petrasovaa
force-pushed
the
wxGUI-thread-exception-when-switching-mapset
branch
from
77efef9 to
20b2923
Compare
petrasovaa
added a commit
to petrasovaa/grass
that referenced
this pull request
Jun 3, 2023
|
Backported to 8.3 and 8.2 |
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching to mapset, we can can encounter this error:
Exception in thread
Thread-4
:
Traceback (most recent call last):
File "/usr/lib/python3.10/threading.py", line 1016, in
_bootstrap_inner
self.run()
File "/home/linduska/.local/lib/python3.10/site-
packages/watchdog/observers/api.py", line 205, in run
self.dispatch_events(self.event_queue)
File "/home/linduska/.local/lib/python3.10/site-
packages/watchdog/observers/api.py", line 381, in
dispatch_events
handler.dispatch(event)
File "/home/linduska/.local/lib/python3.10/site-
packages/watchdog/events.py", line 272, in dispatch
{
File "/home/linduska/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/datacatalog/tree.py", line 179, in
on_modified
gisrc["GISDBASE"], gisrc["LOCATION_NAME"], gisrc["MAPSET"]
KeyError
:
'GISDBASE'
It is related to the fact that when accessing the GISRC file with Database/location/mapset info, at the same time the GISRC file could be accessed by another process.
Fixed by waiting 0.1 sec before reading GISRC.