Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.gunittest: Add check for precision test #2818

Merged
merged 2 commits into from
Feb 8, 2024
Merged

grass.gunittest: Add check for precision test #2818

merged 2 commits into from
Feb 8, 2024

Conversation

wenzeslaus
Copy link
Member

Negative precision value does not make sense, so enforce >=0.

@wenzeslaus
grass.gunittest: Add check for precision test
9d143d9 
Negative precision value does not make sense, so enforce >=0.
@wenzeslaus wenzeslaus added enhancement New feature or request Python Related code is in Python labels Feb 17, 2023
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Feb 17, 2023
echoix
echoix approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, adds an extra safeguard for our tests that would prevent using an invalid value in a test, making us think that a passed test means that the result is ok.

@echoix echoix marked this pull request as ready for review February 8, 2024 05:25
@echoix
Copy link
Member

echoix commented Feb 8, 2024

Exactly one year after, reviving this. And what's funny is that's its 365 commits behind..

@petrasovaa petrasovaa merged commit 8f6b6fa into OSGeo:main Feb 8, 2024
25 checks passed
@wenzeslaus wenzeslaus deleted the gunittest-check-precision branch February 8, 2024 14:34
jadenabrams100 pushed a commit to ncsu-csc472-spring2024/grass-CI-playground that referenced this pull request Feb 21, 2024
@wenzeslaus @jadenabrams100
grass.gunittest: Add check for precision test (OSGeo#2818)
2b1484d 
Negative precision value does not make sense, so enforce >=0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees

@wenzeslaus wenzeslaus

Labels
enhancement New feature or request libraries Python Related code is in Python
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wenzeslaus @echoix @petrasovaa