Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] r.in.pdal fails with PDAL 2.7 #3552

Closed
landam opened this issue Apr 2, 2024 · 2 comments · Fixed by #3567
Closed

[Bug] r.in.pdal fails with PDAL 2.7 #3552

landam opened this issue Apr 2, 2024 · 2 comments · Fixed by #3567
Assignees
@marisn
Labels
bug Something isn't working raster Related to raster data processing
Milestone
8.4.0

Comments

@landam
Copy link
Member

landam commented Apr 2, 2024 •
edited
Loading

Describe the bug

r.in.pdal fails to import LAZ files:

Reading data...
terminate called after throwing an instance of 'pdal::pdal_error'
  what():  writers.grassbinning: Missing value for positional argument 'filename'.

To Reproduce
Steps to reproduce the behavior:

  1. Download sample data https://ags.cuzk.cz/geoprohlizec/?atom=dmr5g (or use attached sample: KRAV59.zip)
  2. Create location in EPSG 5514
  3. Run r.in.pdal -oe input=06/dmr5g/KRAV59.laz output=KRAV59 resolution=1
  4. See error

Expected behavior

The same sample data is successfully imported when GRASS is compiled with PDAL 2.6.

System description (please complete the following information):

  • Operating System: Debian Linux
  • GRASS GIS version main
@landam landam added the bug Something isn't working label Apr 2, 2024
@landam landam added this to the 8.4.0 milestone Apr 2, 2024
@landam landam added the raster Related to raster data processing label Apr 2, 2024
@landam landam changed the title [Bug] r.in.lidar fails with PDAL 2.7 [Bug] r.in.pdal fails with PDAL 2.7 Apr 2, 2024
@marisn marisn self-assigned this Apr 3, 2024
marisn added a commit to marisn/grass that referenced this issue Apr 7, 2024
@marisn
PDAL: use NoFileWriter class for PDAL > 2.7.0 (fixes OSGeo#3552)
5d0732c 
Starting from PDAL 2.7.0 filename is mandatory for Writer class, but
there is a NoFileWriter class that maintains old behaviour.
PDAL/PDAL#4342
@marisn marisn modified the milestones: 8.4.0, 8.3.3 Apr 7, 2024
@nilason nilason linked a pull request Apr 7, 2024 that will close this issue
r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552) #3567
Merged
marisn added a commit that referenced this issue Apr 7, 2024
@marisn @nilason
r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552) (#3567)
544a780 
* r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552)

Starting from PDAL 2.7.0 filename is mandatory for Writer class, but
there is a NoFileWriter class that maintains old behavior.
PDAL/PDAL#4342

---------

Co-authored-by: Nicklas Larsson <[email protected]>
@marisn
Copy link
Contributor

marisn commented Apr 7, 2024

8.3 would also benefit from this fix.

@marisn marisn reopened this Apr 7, 2024
@nilason
Copy link
Contributor

nilason commented Apr 7, 2024

8.3 would also benefit from this fix.

Indeed. The (merged) PR has the "backport" label, so this could be closed. It will not be forgotten.

@landam landam mentioned this issue Apr 12, 2024
Merged
marisn added a commit that referenced this issue Apr 14, 2024
@marisn @nilason
r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552) (#3567)
1adb566 
Starting from PDAL 2.7.0 filename is mandatory for Writer class, but
there is a NoFileWriter class that maintains old behavior.
PDAL/PDAL#4342

---------

Co-authored-by: Nicklas Larsson <[email protected]>
@marisn marisn closed this as completed Apr 14, 2024
@neteler neteler modified the milestones: 8.3.3, 8.4.0 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marisn marisn

Labels
bug Something isn't working raster Related to raster data processing
Projects
None yet
Milestone
8.4.0
Development

Successfully merging a pull request may close this issue.

r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552) marisn/grass
4 participants
@neteler @landam @nilason @marisn