Add 'gdal raster calc' #11850
Add 'gdal raster calc' #11850
Conversation
dbaston
force-pushed
the
gdal-raster-calc
branch
from
9d69380 to
e07f29e
Compare
| * do not already have such a subscript. For example, "X" would be | ||
| * replaced with "X[3]" but "X[1]" would be left untouched. | ||
| */ | ||
| static std::string SetBandIndices(const std::string &origExpression, |
There was a problem hiding this comment.
My reading of the implementation is that if someone would use a variable "X" and "aX", and the intented substitution would be only for "X", then "aX" would also get substituted. No ?
There was a problem hiding this comment.
Line 49 should prevent this. But I'll look at whether I can make test_gdalalg_raster_calc_expression_rewriting less convoluted.
There was a problem hiding this comment.
Hopefully improved by ed4b07a
dbaston
force-pushed
the
gdal-raster-calc
branch
from
0763b4a to
ed4b07a
Compare
apps/gdalalg_raster_calc.cpp
Outdated
| int nX{0}; | ||
| int nY{0}; | ||
| std::array<double, 6> gt{}; | ||
| OGRSpatialReference *srs{nullptr}; |
There was a problem hiding this comment.
I assume srs is leaked. The following (or something along that line) should rather be used. (we should probably have a typdef std::unique_ptr<OGRSpatialReference, OGRSpatialReferenceReleaser> OGRSpatialReferencePtr in ogr_spatialref.h)
| OGRSpatialReference *srs{nullptr}; | |
| std::unique_ptr<OGRSpatialReference, OGRSpatialReferenceReleaser> srs{nullptr}; |
There was a problem hiding this comment.
or maybe just store it as a non-pointer object ?
What does this PR do?
Adds a
gdal raster calctool that provides much of the functionality ofgdal_calc.py. Some differences withgdal_calc.py:muparserexpression engine--input X=file.tifrather than-X file.tif--allBandsflag, the expression can either refer to all bands of a raster (--calc "X + 3") or a single band of a raster (--calc "X[1] + 3")--extent unionand--extent intersectionarguments are not supported, at least for now. I think these may best be handled by separate calls togdal raster mosaic/stackandgdal raster calcbut could be persuaded otherwise without much difficultygdal_calc.pyare not supported (yet?)--input name=dsn[band(s)]Feedback wanted!
What are related issues/pull requests?
#10067
#11209
#11656