Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake build support #27

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Add CMake build support #27

merged 5 commits into from
Jan 29, 2024

Conversation

nilason
Copy link
Collaborator

@nilason nilason commented Jul 21, 2023

Add CMake build support.

Fixes: #24

@nilason
Copy link
Collaborator Author

nilason commented Jul 21, 2023

This "works for me", but it needs fine-tuning, testing and in particular added documentation/comments -- therefore the Draft mode.

However, please do test for general functionality!

@nilason nilason force-pushed the cmake branch 2 times, most recently from 6c519f5 to 905bfe5 Compare July 26, 2023 12:08
@nilason nilason marked this pull request as ready for review July 26, 2023 12:13
@nilason
Copy link
Collaborator Author

nilason commented Jul 26, 2023

This is now open for review. I have so far only tested on Mac.

@nilason nilason force-pushed the cmake branch 3 times, most recently from 5b72508 to 4e8e425 Compare July 27, 2023 10:43
@nilason
Copy link
Collaborator Author

nilason commented Jul 27, 2023

Also passes added CI test with cmake build!

neteler
neteler approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@neteler neteler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your hard work @nilason !

Shall we move this to a new milestone 1.1.0?

@nilason
Copy link
Collaborator Author

nilason commented Aug 16, 2023

Great, thanks for your hard work @nilason !

A bit of warning up for the next victim: GRASS :)

Shall we move this to a new milestone 1.1.0?

Sounds good to me.

(Note, before merging this #28 needs to be merged in present form or modified, I have temporarily included its commit here to appease the CI checks).

@nilason
Copy link
Collaborator Author

nilason commented Sep 18, 2023 •
edited
Loading

Rebased on main after #28, this is now mergeable.

@neteler
Copy link
Member

neteler commented Sep 20, 2023

Which gdal-grass version should we assign here? Another 1.x or even 2.x?

@nilason
Copy link
Collaborator Author

nilason commented Sep 20, 2023

Which gdal-grass version should we assign here? Another 1.x or even 2.x?

This doesn’t break anything, the old autoconf configure is untouched. I think we can stay with 1.x.

@neteler neteler added this to the 1.0.3 milestone Sep 20, 2023
@nilason nilason merged commit bd2269b into OSGeo:main Jan 29, 2024
1 check passed
@nilason nilason deleted the cmake branch January 29, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Add CMake support
2 participants
@nilason @neteler