Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/9060 qa investigation affiliation found notice panel not announced to assistive tech users #2203

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Feature/9060 qa investigation affiliation found notice panel not announced to assistive tech users #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f6b610
9060-qa-investigation-affiliation-found-notice-panel-not-announced-to…
Mar 18, 2024
dc2ae48
9060-qa-investigation-affiliation-found-notice-panel-not-announced-to…
Mar 18, 2024
78a428c
Merge branch 'main' into feature/9060-qa-investigation-affiliation-fo…
leomendoza123 Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/app/register2/components/form-current-employment/form-current-employment.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ <h3 class="orc-font-body" i18n="@@register.affiliationFoud">

<div class="row">
<label
for="organization-input"
id="organization-label"
class="mat-caption"
[ngClass]="{
Expand All @@ -76,6 +75,11 @@ <h3 class="orc-font-body" i18n="@@register.affiliationFoud">
<input
aria-labelledby="organizationLabel"
[readonly]="organizationIsValidAndTouched"
[attr.aria-label]="
rorIdHasBeenMatched
? ariaLabelPrefilledOrganization
: ariaLabelOrganization
"
id="organization-input"
matInput
formControlName="organization"
Expand Down
3 changes: 3 additions & 0 deletions src/app/register2/components/form-current-employment/form-current-employment.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ export class FormCurrentEmploymentComponent extends BaseForm implements OnInit {
ariaLabelStartDate = $localize`:@@shared.startDate:Start date`
ngOrcidYear = $localize`:@@shared.year:Year`
ngOrcidMonth = $localize`:@@shared.month:Month`
ariaLabelOrganization = $localize`:@@register.organization:Organization`
ariaLabelPrefilledOrganization = $localize`:@@register.prefilledOrganization:Organization - We've added an organization based on your email domain`

years = Array(110)
.fill(0)
Expand Down Expand Up @@ -247,6 +249,7 @@ export class FormCurrentEmploymentComponent extends BaseForm implements OnInit {
}

clearForm() {
this.rorIdHasBeenMatched = false
this.form.patchValue({
organization: '',
})
Expand Down
2 changes: 2 additions & 0 deletions src/locale/properties/register/register.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,3 +225,5 @@ register.accesibilityOnlyTheNumberConstrainIsNotMet=Your password must include a
register.accesibilityOnlyTheLetterOrSymbolConstrainIsNotMet=Your password must include at least 1 letter or symbol
register.accesibilityOnlyThe8OrMoreCharactersConstrainIsNotMet=Your password must be 8 or more characters
register.allPasswordContrainsArMet=All password constraints are met
register.organization=Organization
register.prefilledOrganization=Organization - We've added an organization based on your email domain
Loading