Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing full stop in text and add missing error codes #2147

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix: Add missing full stop in text and add missing error codes #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3babb36
fix: Add missing full stop in text and add missing error codes
DanielPalafox Feb 7, 2024
512c321
Merge branch 'main' into fix/9035-registration-unclaimed-deactivated-…
leomendoza123 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/register2/components/form-personal/form-personal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ <h3 i18n="@@register.yourEmailAddresses" class="orc-font-body margin-top-12">
>a deactivated
</ng-container>
<ng-container i18n="@@register.orcidRecord"
>ORCID record</ng-container
>ORCID record.</ng-container
>
<i i18n="@@register.youCannotUseThisEmail">
You cannot use this email address when creating a new ORCID iD.
Expand Down
4 changes: 3 additions & 1 deletion src/app/register2/components/form-personal/form-personal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,9 @@ export class FormPersonalComponent extends BaseForm implements OnInit {
const backendError = this.emails.controls.email.errors?.backendError
return !(
backendError &&
backendError[0] === 'orcid.frontend.verify.duplicate_email' &&
(backendError[0] === 'orcid.frontend.verify.duplicate_email' ||
backendError[0] === 'orcid.frontend.verify.unclaimed_email' ||
backendError[0] === 'orcid.frontend.verify.deactivated_email') &&
!this.nextButtonWasClicked
)
}
Expand Down
2 changes: 1 addition & 1 deletion src/locale/properties/register/register.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ register.isAssociatedWith=is already associated with
register.anExisting=an existing
register.anUnclaimed=an unclaimed
register.aDeactivated=a deactivated
register.orcidRecord=ORCID record
register.orcidRecord=ORCID record.
register.youCannotUseThisEmail=You cannot use this email address when creating a new ORCID iD.
register.emailIsAlreadyAssociated=This email is already associated with an existing ORCID record. Please use a different email address to continue registering a new ORCID iD.
register.resendClaimAddress=Resend a claim email to this email address
Expand Down
Loading