Interceptor #2042
Merged
Interceptor #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| console.log("-------------------------------------------------------------------------------------") |
There was a problem hiding this comment.
Should this logs be remove?
| var method = req.method | ||
| var urlWithParams = req.urlWithParams | ||
| // If the request contains a content type, be sure to set the encoding to utf-8 | ||
| if(['POST', 'PUT'].includes(method)) { |
There was a problem hiding this comment.
We might need to add PATCH in the future.
NO a change we need right now
| // If the request contains a content type, be sure to set the encoding to utf-8 | ||
| if(['POST', 'PUT'].includes(method)) { | ||
| var clonedRequest; | ||
| if(urlWithParams == '/signin/auth.json') { |
There was a problem hiding this comment.
this header excepcion seems to be require for userStatus.json?logUserOut=true, sendReactivation.json, social/signin/auth.json, shibboleth/signin/auth.json, signin/auth.json (all the urls called on SignInService)
Maybe we can declare a class level atribute like
const formUrlEcondedUrls = ["userStatus.json?logUserOut=true", "sendReactivation.json", "social/signin/auth.json", "shibboleth/signin/auth.json", "signin/auth.json"];
And check if a route is in the array
if(formUrlEcondedUrls.includes(urlWithParams)) {
leomendoza123
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.