Merge pull request #2126 from ORCID/fix/batch-fixes-dec-28

fix/batch-fixes-dec-28
ORCID · Dec 28, 2023 · d86c014 · d86c014
2 parents 8306ab7 + 8454a21
commit d86c014
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/app/core/title-service/title.service.ts b/src/app/core/title-service/title.service.ts
@@ -53,7 +53,12 @@ export class TitleService {
   }
 
   setTitle(title: string) {
-    if (title) this._titleService.setTitle(title.replace(/-'/g, '−'))
+    // Use a replacement of the score for arabic titles to avoid the ORCID to be show in reverse
+    const arabic = /[\u0600-\u06FF]/
+    if (arabic.test(title)) {
+      title = title.replace(/-/g, '᭸')
+    }
+    this._titleService.setTitle(title)
   }
 
   setDisplayName(displayedNameWithId: string) {

diff --git a/src/app/layout/user-menu/user-menu.component.scss b/src/app/layout/user-menu/user-menu.component.scss
@@ -27,8 +27,6 @@
         width: 199px;
         overflow: hidden;
         text-overflow: ellipsis;
-        text-align: left;
-        text-align: left;
         white-space: initial;
         word-break: break-word;
       }

diff --git a/src/app/link-account/pages/link-account/link-account.component.html b/src/app/link-account/pages/link-account/link-account.component.html
@@ -28,7 +28,16 @@
                   You are signed into
                 </ng-container>
                 <b>{{ entityDisplayName }}</b>
-                <ng-container i18n="@@linking.as"> as </ng-container>
+                <ng-container
+                  i18n="@@linking.as"
+                  *ngIf="
+                    !signInData.email &&
+                    !signInData.firstName &&
+                    !signInData.lastName
+                  "
+                >
+                  as
+                </ng-container>
                 <b>
                   {{
                     signInData.email