CO2: encapsulate CO2Tables #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way we don't have to drag 6MB of tables into multiple compile units. some flexibility is lost (ie the template parameter for the table), but this is unused in the current code. comment out some templates that do not instance as they are referring to non-existent table members.
|
jenkins build this please |
|
jenkins build this opm-models=771 please |
|
jenkins build this opm-models=771 please |
bska
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way we don't have to drag 6MB of tables into multiple compile units.
some flexibility is lost (ie the template parameter for the table), but this is unused in the current code.
comment out some templates that do not instance as they are referring to non-existent table members.
Waiting for #3246