GasPvtThermal: implement the IsothermalPvt using a variant #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace SFINAE, void pointers and macro usage by visitor overload sets
to help break circular dependencies
this allows us to break the circular dependency between GasPvtThermal and GasPvtMultiplexer which forces us to use pointer semantics. dropping the pointer semantics allows us to remove explicit ctor, copy ctor, assignment and comparison operators
to reduce code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #3279
Waiting for #3246
this allows us to break the circular dependency between GasPvtThermal
and GasPvtMultiplexer which forces us to use pointer semantics.
dropping the pointer semantics allows us to remove explicit ctor,
copy ctor, assignment and comparison operators