LiveOilPvt: encapsulate EclipseState w/ friends #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
force-pushed
the
liveoilpvt_encapsulate
branch
2 times, most recently
from
a138898 to
6a66e1a
Compare
thus encapsulating EclipseState, Schedule and TableManager
this is user-provided data. instead throw an exception
drop unused constructors and explicit comparison operator
akva2
force-pushed
the
liveoilpvt_encapsulate
branch
from
6a66e1a to
219536d
Compare
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace asserts on user-defined data with exceptions.
Waiting for #3246