ConstantCompressibilityOilPvt: encapsulate EclipseState w/ friends #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
changed the title
akva2
force-pushed
the
constantcompressibilityoilpvt_encapsulate
branch
from
11d415f to
de485b0
Compare
…unit thus encapsulating EclipseState and TableManager
this is user-provided data. instead throw an exception
drop unused constructors and explicit comparison operator
akva2
force-pushed
the
constantcompressibilityoilpvt_encapsulate
branch
from
de485b0 to
a26cea5
Compare
|
jenkins build this please |
bska
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace assert on user provided data with exception.
Waiting for #3246