ConstantCompressibilityBrinePvt: encapsulate EclipseState w/ friends

[akva2]

And replace naked throw with OPM_THROW.

Waiting for #3246

[akva2]

jenkins build this please

[akva2]

jenkins build this please

[bska]

Looks good to me. Please merge into master when the build check is green.

[bska]

Hm, it happened again and this time I don't know how to work around the missing Dune headers. Any suggestions are welcome, but I suppose we may have to accept linking opm-common to dune-common now.

---

ork/opm/src/opm.kdev/opm-common/external/fmtlib/include -pipe -pedantic -Wall -Wextra -Wcast-align -Wcast-qual -Wchar-subscripts -Wformat-nonliteral -Wmissing-declarations -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -fopenmp -pthread -ggdb3 -O0 -DDEBUG -fPIC   -fopenmp -std=c++17 -MD -MT CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o -MF CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o.d -o CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o -c /home/bska/work/opm/src/opm.kdev/opm-common/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp
In file included from /home/bska/work/opm/src/opm.kdev/opm-common/opm/material/densead/Math.hpp:35,
                 from /home/bska/work/opm/src/opm.kdev/opm-common/opm/material/common/Tabulated1DFunction.hpp:31,
                 from /home/bska/work/opm/src/opm.kdev/opm-common/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.hpp:30,
                 from /home/bska/work/opm/src/opm.kdev/opm-common/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp:25:
/home/bska/work/opm/src/opm.kdev/opm-common/opm/material/densead/Evaluation.hpp:618:10: fatal error: dune/common/ftraits.hh: No such file or directory
  618 | #include <dune/common/ftraits.hh>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

[akva2]

isn't the cure the same? remove Math.hpp include from the Tabulated1DFunction. it's not needed before instancing the templates, which does not happen in opm-common (apart from the tests).

[bska]

remove Math.hpp include from the Tabulated1DFunction. it's not needed before instancing the templates, which does not happen in opm-common

No, this one seems more involved. If I do that I just get the build failure below

---

[4/310] Building CXX object CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o
FAILED: CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o 
/usr/bin/g++  -DBOOST_ALL_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DFMT_HEADER_ONLY -DHAVE_CONFIG_H=1 -I. -I/home/bska/work/opm/src/opm.kdev/opm-common/external/cjson -Iinclude -I/home/bska/work/opm/src/opm.kdev/opm-common -isystem /home/bska/work/opm/src/opm.kdev/opm-common/external/fmtlib/include -pipe -pedantic -Wall -Wextra -Wcast-align -Wcast-qual -Wchar-subscripts -Wformat-nonliteral -Wmissing-declarations -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -fopenmp -pthread -ggdb3 -O0 -DDEBUG -fPIC   -fopenmp -std=c++17 -MD -MT CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o -MF CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o.d -o CMakeFiles/opmcommon.dir/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp.o -c /home/bska/work/opm/src/opm.kdev/opm-common/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp
In file included from /home/bska/work/opm/src/opm.kdev/opm-common/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.hpp:30,
                 from /home/bska/work/opm/src/opm.kdev/opm-common/src/opm/material/fluidsystems/blackoilpvt/ConstantCompressibilityBrinePvt.cpp:25:
/home/bska/work/opm/src/opm.kdev/opm-common/opm/material/common/Tabulated1DFunction.hpp: In member function ‘size_t Opm::Tabulated1DFunction<Scalar>::findSegmentIndex_(const Evaluation&, bool) const’:
/home/bska/work/opm/src/opm.kdev/opm-common/opm/material/common/Tabulated1DFunction.hpp:493:116: error: ‘getValue’ is not a member of ‘Opm’
  493 |                 sstream << "Problematic interpolation/extrapolation segment is found for the input value " << Opm::getValue(x)
      |                                                                                                                    ^~~~~~~~

[akva2]

right. i see it. we need deeper surgery. try commenting the dune traits include + struct at the bottom of Evaluation.hpp. it likely make some stuff fail but i don't know what exactly. we need to stick that part in a separate header, but as it's codegen stuff it's a bit too much for me to handle right now and repeated builds on my poor little laptop takes ages.