Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EclMaterialLawManager: move most code to separate compile unit #3253

Merged
merged 1 commit into from
Dec 21, 2022
Merged

EclMaterialLawManager: move most code to separate compile unit #3253

merged 1 commit into from
Dec 21, 2022

Conversation

akva2
Copy link
Member

@akva2 akva2 commented Dec 12, 2022 •
edited
Loading

To encapsulate various types.

Waiting for #3246

@akva2 akva2 marked this pull request as draft December 12, 2022 19:46
@akva2
Copy link
Member Author

akva2 commented Dec 12, 2022

jenkins build this please

@akva2 akva2 marked this pull request as ready for review December 13, 2022 07:01
@akva2 akva2 force-pushed the eclmateriallawmanager_encapsulate branch from 4c424ef to 848d5ff Compare December 13, 2022 07:06
@akva2
Copy link
Member Author

akva2 commented Dec 13, 2022

jenkins build this please

@akva2
Copy link
Member Author

akva2 commented Dec 13, 2022

benchmark please

bska
bska approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Please merge when you're satisfied that there's no appreciable performance reduction.

@akva2 akva2 force-pushed the eclmateriallawmanager_encapsulate branch from 848d5ff to cbdff54 Compare December 13, 2022 10:38
@akva2 akva2 marked this pull request as draft December 13, 2022 11:24
@ytelses
Copy link

ytelses commented Dec 13, 2022

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 1.05
opm-git OPM Benchmark: drogon - Threads: 8 1.003
opm-git OPM Benchmark: smeaheia - Threads: 1 1.003
opm-git OPM Benchmark: smeaheia - Threads: 8 1.01
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 1.01
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.005
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 1.003
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 1.001
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=1886

@akva2 akva2 marked this pull request as ready for review December 21, 2022 12:44
@akva2
Copy link
Member Author

akva2 commented Dec 21, 2022

jenkins build this please

bska
bska approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please merge when the build check is green!

@akva2 akva2 merged commit 12ff606 into OPM:master Dec 21, 2022
@akva2 akva2 deleted the eclmateriallawmanager_encapsulate branch December 21, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akva2 @ytelses @bska