Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SetECDsaPublicKey and padd with leading zeros #2962

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Jan 23, 2025

Proposed changes

Simplify SetECDsaPublicKey and pad with leading zeros the public key point coordinates to avoid cases where they are reported as being of different size.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrsuciu mrsuciu requested a review from romanett January 23, 2025 20:26
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.43%. Comparing base (a2f761e) to head (4e1df43).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   55.43%   55.43%   -0.01%     
==========================================
  Files         352      352              
  Lines       67858    67859       +1     
  Branches    13908    13908              
==========================================
  Hits        37616    37616              
+ Misses      26115    26112       -3     
- Partials     4127     4131       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romanett romanett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes previously failing test using this method with ECC Public Key.

Maybe also set hash algorithm size:

SetECCurve(m_ecdsaPublicKey.ExportParameters(false).Curve);

@mrsuciu mrsuciu merged commit f7815c8 into OPCFoundation:master Jan 24, 2025
77 checks passed
mrsuciu added a commit that referenced this pull request Jan 24, 2025
* Simplify SetECDsaPublicKey and padd with leading zeros

* Added SetECCurve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants