Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add ECC Certificates to various tests #2961

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

Proposed changes

  • Test CRLs with every Certificate type
  • Test GDS Pull with every Certificate type
  • Test GDS Push with every Certificate type

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett requested a review from mrsuciu January 23, 2025 17:51
@romanett romanett changed the title [Test] [Test] Add ECC Certificates to various tests Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (f7815c8) to head (fd7f9c3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
+ Coverage   55.40%   55.57%   +0.17%     
==========================================
  Files         352      352              
  Lines       67859    67857       -2     
  Branches    13908    13905       -3     
==========================================
+ Hits        37598    37714     +116     
+ Misses      26136    26045      -91     
+ Partials     4125     4098      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrsuciu mrsuciu closed this Jan 28, 2025
@romanett romanett reopened this Jan 28, 2025
@romanett romanett marked this pull request as ready for review January 29, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants