Some cleanup of the new APIs and Union implementation. #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.05.04-final-release-fixes #2927 +/- ##
=============================================================
Coverage 54.79% 54.80%
=============================================================
Files 349 349
Lines 66372 66680 +308
Branches 13622 13738 +116
=============================================================
+ Hits 36371 36543 +172
- Misses 26011 26130 +119
- Partials 3990 4007 +17 ☔ View full report in Codecov by Sentry. |
* #2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * #2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.
…nConfigurationBuilder (#2909) Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier
Merge cherrypicks from master in develop branch
opcfoundation-org
requested changes
Jan 8, 2025
randy-armstrong
approved these changes
Jan 13, 2025
|
working on some improvements to use StringCollection instead of an EnumType in the Switchfield API. Also try to move some of the logic to the encoders. |
- nodeset xmlzip is created in obj folders if multiple targets are built in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enhancements to Encoding/Decoding Methods:
OptionalFieldsComplexType.cs: ReplacedWriteUInt32withWriteEncodingMaskand added logic to handle JSON decoders when the encoding mask is implicitly defined. [1] [2]UnionComplexType.cs: IntroducedWriteSwitchFieldand updated logic to support reversible JSON encoding. [1] [2] [3]Configuration Improvements:
ApplicationConfigurationBuilder.cs: AddedSetHiResClockDisabledmethod to control high-resolution clock settings.IApplicationConfigurationBuilder.cs: IntroducedIApplicationConfigurationBuilderGlobalConfigurationinterface for global configuration settings.Project Settings and Cleanup:
Opc.Ua.Client.csproj: Removed unnecessaryPackageReferenceforSystem.Diagnostics.DiagnosticSource.Opc.Ua.Core.csproj: Updated the build process for zipping the NodeSet2 file and allowed unsafe blocks. [1] [2]Miscellaneous Fixes:
CustomNodeManager.cs: Renamed variableerrortocallResultand ensured the actual result of the original call is returned. [1] [2]README.md: Corrected the release month from December to January.Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...