Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 2854 - ConditionRefreshAsync always results in BadNodeIdUnknown #2876

Conversation

Archie-Miller
Copy link
Contributor

@Archie-Miller Archie-Miller commented Dec 2, 2024

Also adds functionality for ConditionRefresh2

Proposed changes

Fix issue in Client library, ConditionRefreshAsync was missing the ObjectId in the function call.
Also adds functionality for ConditionRefresh2 for both Sync and Asyn

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Ideally, system tests could be created. They would take substantial effort to properly test.

Also adds functionality for ConditionRefresh2
@Archie-Miller Archie-Miller requested a review from mregen December 2, 2024 22:03
@Archie-Miller Archie-Miller linked an issue Dec 2, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 55.27%. Comparing base (6aedc78) to head (0eecd8e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...es/Opc.Ua.Client/Subscription/SubscriptionAsync.cs 6.66% 14 Missing ⚠️
...braries/Opc.Ua.Client/Subscription/Subscription.cs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
- Coverage   55.33%   55.27%   -0.06%     
==========================================
  Files         352      352              
  Lines       67343    67370      +27     
  Branches    13808    13808              
==========================================
- Hits        37262    37242      -20     
- Misses      26002    26049      +47     
  Partials     4079     4079              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen merged commit bc0b181 into OPCFoundation:master Dec 3, 2024
75 of 77 checks passed
mregen pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConditionRefreshAsync always results in BadNodeIdUnknown
2 participants