Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server doesn't start up with mixed https endpoints #2789

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Oct 9, 2024

Proposed changes

The server doesn't start up with mixed https endpoints. Currently there is support for opc.https and https endpoints, to support legacy implementations. However, if both endpoints are specified on different ports, the second endpoint in the list is ignored.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.77%. Comparing base (cf2e788) to head (e6d10e3).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2789      +/-   ##
==========================================
+ Coverage   55.04%   55.77%   +0.73%     
==========================================
  Files         349      349              
  Lines       65697    68659    +2962     
  Branches    13441    14502    +1061     
==========================================
+ Hits        36162    38294    +2132     
- Misses      25688    26315     +627     
- Partials     3847     4050     +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen marked this pull request as ready for review October 9, 2024 06:24
@mregen mregen merged commit 23b8502 into master Oct 10, 2024
120 checks passed
@mregen mregen deleted the httpsstartupfix branch October 10, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server fails to start up if mixed https endpoints are specified (opc.https + https)
2 participants