Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codesmells. No functional changes and bug fixes. #2368

Merged
merged 25 commits into from
Nov 7, 2023

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Nov 6, 2023

Proposed changes

Fix many warnings to improve code quality or simplify the code.

  • make internal variables readonly if possible
  • IDE1006: fix coding conventions if internal (e.g. Async suffix)
  • CA1822: make internal/private functions static if no member access
  • refactor type casts
  • IDE0008: use explicit type where it is not obvious

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 865 lines in your changes are missing coverage. Please review.

Comparison is base (71ad9af) 53.92% compared to head (37d830d) 53.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2368      +/-   ##
==========================================
- Coverage   53.92%   53.79%   -0.14%     
==========================================
  Files         331      331              
  Lines       64190    63816     -374     
  Branches    13105    13100       -5     
==========================================
- Hits        34613    34327     -286     
+ Misses      25895    25765     -130     
- Partials     3682     3724      +42     
Files Coverage Δ
Libraries/Opc.Ua.Client/ReverseConnectManager.cs 55.55% <100.00%> (-0.17%) ⬇️
Libraries/Opc.Ua.Client/SessionReconnectHandler.cs 38.02% <100.00%> (ø)
Libraries/Opc.Ua.Client/SubscriptionAsync.cs 62.73% <ø> (ø)
...aries/Opc.Ua.PubSub/DataSetDecodeErrorEventArgs.cs 0.00% <ø> (ø)
...aries/Opc.Ua.PubSub/Encoding/JsonDataSetMessage.cs 77.58% <100.00%> (-0.38%) ⬇️
Libraries/Opc.Ua.PubSub/UaNetworkMessage.cs 75.00% <ø> (ø)
Libraries/Opc.Ua.PubSub/UaPublisher.cs 46.15% <ø> (ø)
...es/Opc.Ua.Security.Certificates/Common/AsnUtils.cs 58.62% <100.00%> (ø)
...pc.Ua.Security.Certificates/Common/X509Defaults.cs 100.00% <ø> (ø)
.../Extensions/X509AuthorityKeyIdentifierExtension.cs 79.13% <100.00%> (ø)
... and 169 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen marked this pull request as ready for review November 6, 2023 16:22
@mregen mregen requested review from mrsuciu and EWolfAtGit November 6, 2023 16:22
@mregen mregen merged commit 4c0880c into OPCFoundation:master Nov 7, 2023
@mregen mregen deleted the codesmells branch November 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants