Array xmlns encoding/decoding

[MarkusHorstmann]

Proposed changes

XmlEncoder.WriteArray and XmlDecoder.ReadArray always use the OPC UA XML namespace (http://opcfoundation.org/UA/2008/02/Types.xsd) for the field element that contains the array, regardless of the namespace that the caller may have pushed.

Related Issues

• Fixes XmlEncoder/Decoder always use the OPC UA XML namespace for the containing field of a one-dimensional array #2308

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

[codecov]

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (37252f3) 53.27% compared to head (15bb119) 53.61%.

Files	Patch %	Lines
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs	58.49%	17 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   53.27%   53.61%   +0.33%     
==========================================
  Files         331      331              
  Lines       63816    63811       -5     
  Branches    13100    13098       -2     
==========================================
+ Hits        34001    34210     +209     
+ Misses      26065    25874     -191     
+ Partials     3750     3727      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mregen]

                    PushNamespace(Namespaces.OpcUaXsd);

does this also have to be removed?

---

Refers to: Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs:2118 in a9cc81b. [](commit_id = a9cc81b, deletion_comment = False)

[MarkusHorstmann]

                    PushNamespace(Namespaces.OpcUaXsd);

does this also have to be removed?

Refers to: Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs:2118 in a9cc81b. [](commit_id = a9cc81b, deletion_comment = False)

Not seeing a PushNamespace at this line. Which method is it in? I did double check all PushNamespace calls in XmlEncoder.cs and they all seem to be correct (before reading an element defined by a core type).

[opcfoundation-org]

I am concerned the fix addresses the issue with arrays nested within a type but it may break top level arrays.

[mregen]

Thanks for the contribution!
upon discussion today in the user group this PR is approved.

[mregen]

@MarkusHorstmann please resolve the merge conflict.

[MarkusHorstmann]

@MarkusHorstmann please resolve the merge conflict.

Done. The test failures don't seem to be related to my changes. Please let me know if you think otherwise.