Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a worker thread for condition refresh #2105

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Mar 21, 2023

Proposed changes

Currently ConditionRefresh requests are queued and executed on tasks. This change adds requests to a queue and refresh is executed by a worker, limiting the amount of threads that can execute concurrently.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@mregen mregen requested a review from mrsuciu March 21, 2023 02:12
@mregen mregen added this to the 1.4.371.60 bug fixes milestone Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #2105 (434352d) into master (bd0f02a) will increase coverage by 0.19%.
The diff coverage is 64.51%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   57.88%   58.08%   +0.19%     
==========================================
  Files         324      324              
  Lines       61606    61649      +43     
==========================================
+ Hits        35663    35807     +144     
+ Misses      25943    25842     -101     
Impacted Files Coverage Δ
.../Opc.Ua.Server/Subscription/SubscriptionManager.cs 70.87% <63.33%> (+1.03%) ⬆️
...aries/Opc.Ua.Server/NodeManager/ResourceManager.cs 65.76% <100.00%> (-0.18%) ⬇️

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mregen mregen merged commit 1da07f9 into master Mar 21, 2023
@mregen mregen deleted the conditionrefreshworker branch March 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants