925 - Routing Styling Changes #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishtaplin
force-pushed
the
routing-update-design
branch
from
07b7a05 to
a39ebab
Compare
pricea1
approved these changes
Aug 2, 2019
| <option value="all" selected> | ||
| All of | ||
| </option> | ||
| <option value="any" disabled> |
There was a problem hiding this comment.
Is it worth making it more obvious its disabled until its functional? To me, it looked as though All of was in bold because its selected and Any of was a selectable option. Same for Answer/Metadata option.
| @@ -154,6 +155,7 @@ Resolvers.Mutation = { | |||
| }, pages); | |||
|
|
|||
| const routing = page.routing; | |||
|
|
|||
There was a problem hiding this comment.
This file hasn't been modified and can be removed from commit
There was a problem hiding this comment.
idk why it's included or how to remove!
There was a problem hiding this comment.
Just remove the newlines on 149 and 158 and commit again.
heofs
suggested changes
Aug 2, 2019
...or/src/App/page/Routing/RoutingPage/RoutingEditor/RuleEditor/BinaryExpressionEditor/index.js
Show resolved
Hide resolved
heofs
approved these changes
Aug 2, 2019
heofs
force-pushed
the
routing-update-design
branch
from
686e1ef to
f59e3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Updates routing UI to meet latest designs:
BinaryExpressionEditorbuttons inlineOther changes:
TabBodycomponent fromEditorLayout/Tabs—replaced usage with genericPanelcomponent.How to review
BinaryExpressionEditorinstances