[Experimental] ONNI v2 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cycheng
reviewed
Oct 4, 2018
| uint64_t max_size = 0; | ||
| for (ComputeOperand *co : pModule.getComputeOperands()) { | ||
| if (ComputeMemOperand *mem = dyn_cast<ComputeMemOperand>(co)) { | ||
| Value *v = co->getValue(); |
cycheng
reviewed
Oct 4, 2018
| if (ComputeMemOperand *mem = dyn_cast<ComputeMemOperand>(co)) { | ||
| Value *v = co->getValue(); | ||
| if (mem->isInput()) { | ||
| // XXX: Multiple inputs |
There was a problem hiding this comment.
Use assert? assert(inputNum == 1 && "TODO: Support multiple inputs);
cycheng
reviewed
Oct 4, 2018
| // TODO: Refactor this. We need a table printer. | ||
| size_t val_len = 8; | ||
| for (ComputeOperator &cm : *pModule.getRootComputeGraph()) { | ||
| if (dyn_cast<InputOperator>(&cm)) continue; |
There was a problem hiding this comment.
How about add a function:
bool skipInMemStatistics(ComputeOperator *pCm) {
if (isa(pCm) ||
isa<...> || isa<...>)
return true;
return false;
}
cycheng
reviewed
Oct 4, 2018
| @@ -27,6 +30,9 @@ Pass::ReturnType CountOperatorsPass::runOnModule(Module &pModule) | |||
| uint64_t total = 0; | |||
|
|
|||
| for (ComputeOperator &cm : *pModule.getRootComputeGraph()) { | |||
| if (dyn_cast<InputOperator>(&cm)) continue; | |||
There was a problem hiding this comment.
Replace with a function? IsIOWOperator() or SkipInCountStatistics()?
There was a problem hiding this comment.
Ok, that's Great! Thanks a lot!
|
LTGM! (But please keep fixing TODO list ;P) |
a127a127
commented
Oct 4, 2018
| if (ComputeMemOperand *mem = dyn_cast<ComputeMemOperand>(co)) { | ||
| Value *v = co->getValue(); | ||
| if (mem->isInput()) { | ||
| // XXX: Multiple inputs |
| uint64_t max_size = 0; | ||
| for (ComputeOperand *co : pModule.getComputeOperands()) { | ||
| if (ComputeMemOperand *mem = dyn_cast<ComputeMemOperand>(co)) { | ||
| Value *v = co->getValue(); |
| // TODO: Refactor this. We need a table printer. | ||
| size_t val_len = 8; | ||
| for (ComputeOperator &cm : *pModule.getRootComputeGraph()) { | ||
| if (dyn_cast<InputOperator>(&cm)) continue; |
| @@ -27,6 +30,9 @@ Pass::ReturnType CountOperatorsPass::runOnModule(Module &pModule) | |||
| uint64_t total = 0; | |||
|
|
|||
| for (ComputeOperator &cm : *pModule.getRootComputeGraph()) { | |||
| if (dyn_cast<InputOperator>(&cm)) continue; | |||
There was a problem hiding this comment.
Ok, that's Great! Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review:
Print memory usage and overall time.
Print the final ONNC IR before inference.
Print the operator counts.
Print the per layer inference time.
Print internal memory layout.