Added missing "extern" to declarations: #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOG_DLEP_RADIO in dlep_internal.h LOG_NL80211 in nl80211_internal.h LOG_MPR in mpr_internal.h LOG_NHDP, LOG_NHDP_R, LOG_NHDP_W in nhdp_internal.h LOG_OLSRV2, LOG_OLSRV2_R, LOG_OLSRV2_ROUTING, LOG_OLSRV2_W in olsrv2_internal.h
|
@aJunk , do you see anything open? Recently there where some PR merges in regards to the missing "extern" statements. |
Looks good to me now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOG_DLEP_RADIO in dlep_internal.h
LOG_NL80211 in nl80211_internal.h
LOG_MPR in mpr_internal.h
LOG_NHDP, LOG_NHDP_R, LOG_NHDP_W in nhdp_internal.h
LOG_OLSRV2, LOG_OLSRV2_R, LOG_OLSRV2_ROUTING, LOG_OLSRV2_W in olsrv2_internal.h
These caused symbol conflicts in GCC 10 as well as in GCC <10 when linking with '-fno-common'.
(see issue #28)