Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userguide: http.cookie keyword update v2 #8370

Closed

Conversation

jmtaylor90
Copy link
Contributor

@jmtaylor90 jmtaylor90 commented Jan 12, 2023

Signed-off-by: jason taylor [email protected]

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Part of https://redmine.openinfosecfoundation.org/issues/3025

Describe changes:

  • reformatted to <80 character lines as requested in PR review
  • squashed unnecessary commits as request in previous PR review

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #8370 (1f504b4) into master (55c4834) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8370      +/-   ##
==========================================
+ Coverage   81.92%   81.94%   +0.02%     
==========================================
  Files         963      963              
  Lines      277674   277674              
==========================================
+ Hits       227472   227539      +67     
+ Misses      50202    50135      -67     
Flag Coverage Δ
fuzzcorpus 64.19% <ø> (+0.09%) ⬆️
suricata-verify 59.64% <ø> (-0.04%) ⬇️
unittests 63.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the typo/doc update No code change : only doc or typo fixes label Jan 12, 2023
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

This was referenced Jan 17, 2023
@victorjulien
Copy link
Member

Merged in #8389, thanks!

@jmtaylor90 jmtaylor90 deleted the userguide-http-cookie-update-v2 branch February 6, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

3 participants