Tx files/v82 #7521
Closed
Tx files/v82 #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua: fix file fields Fix file_id field sometimes getting overwritten by the tx_id field.
Add per state structure for storing flags and other variables.
In preparation of new flags.
output/tx: own file/filedata thread data output/file(data): cleanups FILETX: register tx after file/filedata FILETX: file output FILETX: filedata output FILETX: id's for file/filedata as tx loggers FILETX: runmode needs to enable tx if file logging is enabled WIP output files: use eof to trigger logging like with tx SQUASH output-tx. FIX flags UPDATE ready logic WIP output-tx SQUASH output-tx
|
Information: QA ran without warnings. Pipeline 7777 |
Closed
Closed
|
replaced by #7735 |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 23, 2025
Instead of ip-only specific flags, reuse the FLOW_PKT_TOSERVER_FIRST and FLOW_PKT_TOCLIENT_FIRST flags. Leads to a minor behavior change: If a one sided flow leads to a flow end packet in the opposite direction, the opposing packet no longer leads to a ip-only match as the flow end pseudo packet won't have the FLOW_PKT_*_FIRST flag set. Ticket: OISF#7521.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 23, 2025
Instead of ip-only specific flags, reuse the FLOW_PKT_TOSERVER_FIRST and FLOW_PKT_TOCLIENT_FIRST flags. Fixes false positives on one sided streams that trigger a opposing flow timeout packet at the flow's end. That pseudo packet would trigger a match even though it shouldn't. Ticket: OISF#7521.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 27, 2025
Instead of ip-only specific flags, reuse the FLOW_PKT_TOSERVER_FIRST and FLOW_PKT_TOCLIENT_FIRST flags. Fixes false positives on one sided streams that trigger a opposing flow timeout packet at the flow's end. That pseudo packet would trigger a match even though it shouldn't. Ticket: OISF#7521.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 28, 2025
Instead of ip-only specific flags, reuse the FLOW_PKT_TOSERVER_FIRST and FLOW_PKT_TOCLIENT_FIRST flags. Fixes false positives on one sided streams that trigger a opposing flow timeout packet at the flow's end. That pseudo packet would trigger a match even though it shouldn't. Ticket: OISF#7521.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 29, 2025
Instead of ip-only specific flags, reuse the FLOW_PKT_TOSERVER_FIRST and FLOW_PKT_TOCLIENT_FIRST flags. Fixes false positives on one sided streams that trigger a opposing flow timeout packet at the flow's end. That pseudo packet would trigger a match even though it shouldn't. Ticket: OISF#7521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft to trigger CI/QA. Commit check will certainly fail.
suricata-verify-pr: 847