Smb rename #7498
Closed
Smb rename #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if configuration provded no value as was done in C before e5c948d
|
ERROR: ERROR: QA failed on smb_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7737 |
This was referenced Jun 8, 2022
As an SMB2 async response does not have a tree id, even if the request has it. Per spec, MessageId should be enough to identifiy a message request and response uniquely across all messages that are sent on the same SMB2 Protocol transport connection. So, the tree id is redundant anyways.
|
Force-pushed schema.json changes to get CI to run again |
Codecov Report
@@ Coverage Diff @@
## master #7498 +/- ##
==========================================
- Coverage 75.83% 75.78% -0.06%
==========================================
Files 655 655
Lines 186236 186235 -1
==========================================
- Hits 141239 141139 -100
- Misses 44997 45096 +99
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on smb_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7752 |
|
Replaced by #7536 |
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 27, 2025
- Remove rs_prefix - Remove no_mangle and pub when not needed Related to ticket: OISF#7498
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 27, 2025
- Remove rs_prefix - Remove no_mangle and pub when not needed Related to ticket: OISF#7498
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 27, 2025
- replace rs_ prefixed names with SC - remove no_mangle and pub where not needed - remove some unused functions Related to ticket: OISF#7498
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 27, 2025
Related to ticket: OISF#7498
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 27, 2025
- remove rs_prefix, replace with SC if needed - remove pub and no_mangle where not needed - remove some unused functions and fields Related to ticket: OISF#7498
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 28, 2025
- remove rs_prefix, replace with SC if needed - remove pub and no_mangle where not needed - remove some unused functions and fields Related to ticket: OISF#7498
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 28, 2025
- Remove rs_prefix - Remove no_mangle and pub when not needed Related to ticket: OISF#7498
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 28, 2025
- replace rs_ prefixed names with SC - remove no_mangle and pub where not needed - remove some unused functions Related to ticket: OISF#7498
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 28, 2025
Related to ticket: OISF#7498
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 28, 2025
- remove rs_prefix, replace with SC if needed - remove pub and no_mangle where not needed - remove some unused functions and fields Related to ticket: OISF#7498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
TODO
Maybe related to https://redmine.openinfosecfoundation.org/issues/5332
See also #7497
Describe changes:
suricata-verify-pr: 843