Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql 5307 v6 #7456

Closed
wants to merge 6 commits into from
Closed

Codeql 5307 v6 #7456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04bb7c2
ci: adds CodeQL workflow and LGTM support
Yonah78 Mar 28, 2022
d268a16
util: better hex print function
catenacyber Apr 16, 2022
bd42b46
util: check for unsigned overflow in rohash
catenacyber Apr 16, 2022
08f7351
file: use functions on fd to avoid toctou
catenacyber Apr 16, 2022
166c968
detect: parsing avoiding infinite loop
catenacyber Apr 16, 2022
0f34da6
rust: cbindgen first verifies existing bindings
catenacyber Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rust: cbindgen first verifies existing bindings 
So as not to recompile every C file inclusing rust.h
  • Loading branch information
@catenacyber
catenacyber committed Jun 1, 2022
commit 0f34da6db6fab15e78b5f3d4b4fa27e7f6aad5cf
3 changes: 1 addition & 2 deletions rust/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ vendor:

if HAVE_CBINDGEN
gen/rust-bindings.h: $(RUST_SURICATA_LIB)
rm -f gen/rust-bindings.h
cbindgen --config $(abs_top_srcdir)/rust/cbindgen.toml \
--quiet --output $(abs_top_builddir)/rust/gen/rust-bindings.h
--quiet --verify --output $(abs_top_builddir)/rust/gen/rust-bindings.h || true
else
gen/rust-bindings.h:
endif
Expand Down
2 changes: 1 addition & 1 deletion src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ suricata_SOURCES = main.c
# the library search path.
suricata_LDFLAGS = $(all_libraries) ${SECLDFLAGS}
suricata_LDADD = libsuricata_c.a $(RUST_SURICATA_LIB) $(HTP_LDADD) $(RUST_LDADD)
suricata_DEPENDENCIES = libsuricata_c.a
suricata_DEPENDENCIES = libsuricata_c.a $(RUST_SURICATA_LIB)

if BUILD_SHARED_LIBRARY
libsuricata.so.$(VERSION): libsuricata_c.a
Expand Down