github-actions: bump actions/upload-artifact from 3.0.0 to 3.1.0 #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6673cd0...3cea537) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## master #7417 +/- ##
==========================================
- Coverage 75.94% 75.87% -0.07%
==========================================
Files 656 656
Lines 189916 189917 +1
==========================================
- Hits 144233 144104 -129
- Misses 45683 45813 +130
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
|
Looks like actions/upload-artifact is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/github_actions/actions/upload-artifact-3.1.0
branch
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 24, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 24, 2025
Fixes rustc compiler warning:
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 24, 2025
Fixes Rust compiler warning:
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 25, 2025
Other than some debug output on initialization we don't take mutable
references to these static mut's.
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
= note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 25, 2025
It doesn't appear to be needed. The vec being cleared is only set once per run, so never needs to be cleared. Removes one point where we have to supress the static_mut_refs compiler warning. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 25, 2025
Allows us to get rid of the global supression. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 25, 2025
As references to static mutables are highly discouraged, remove the global suppressing of the compiler warning. Each use case can be suppressed as needed. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 26, 2025
It doesn't appear to be needed. The vec being cleared is only set once per run, so never needs to be cleared. Removes one point where we have to supress the static_mut_refs compiler warning. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 26, 2025
Allows us to get rid of the global supression. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 26, 2025
Simply wrapping in a function removes static_mut_refs compiler warning. Ticket: OISF#7417
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 26, 2025
As references to static mutables are highly discouraged, remove the global suppressing of the compiler warning. Each use case can be suppressed as needed. Ticket: OISF#7417
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 27, 2025
It doesn't appear to be needed. The vec being cleared is only set once per run, so never needs to be cleared. Removes one point where we have to supress the static_mut_refs compiler warning. Ticket: OISF#7417
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 27, 2025
Allows us to get rid of the global supression. Ticket: OISF#7417
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 27, 2025
Simply wrapping in a function removes static_mut_refs compiler warning. Ticket: OISF#7417
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 27, 2025
As references to static mutables are highly discouraged, remove the global suppressing of the compiler warning. Each use case can be suppressed as needed. Ticket: OISF#7417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 3.0.0 to 3.1.0.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
3cea537Merge pull request #327 from actions/robherley/artifact-1.1.0849aa77nvm use 12 & npm run release4d39869recompile with correct ncc version2e0d362bump@actions/artifactto 1.1.009a5d6aMerge pull request #320 from actions/dependabot/npm_and_yarn/ansi-regex-4.1.1189315dBump ansi-regex from 4.1.0 to 4.1.1d159c2dMerge pull request #297 from actions/dependabot/npm_and_yarn/ajv-6.12.6c26a7baBump ajv from 6.11.0 to 6.12.66ed6c72Merge pull request #303 from actions/dependabot/npm_and_yarn/yargs-parser-13.1.22aeee26Bump yargs-parser from 13.1.1 to 13.1.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)