rules: use primary default-rule-path if set on command line #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reloading rules, respect `--set default-rule-path=...` from the command line if set. Previously the rule reload would always take the default-rule-path from the configuration file, even if overrided on the command line. Issue: OISF#1911
|
ERROR: ERROR: QA failed on tlpw1_files_sha256.
Pipeline 7312 |
|
Fixed up clang-format in staging. |
|
Merged as part of #7423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading rules, respect
--set default-rule-path=...from thecommand line if set.
Previously the rule reload would always take the default-rule-path from
the configuration file, even if overrided on the command line.
This is a rather narrow fix for the broader issue discussed in issue 1911, but
I think thats better suited for a much larger fix, which I've started to
discuss in https://redmine.openinfosecfoundation.org/issues/4782.
Issue: https://redmine.openinfosecfoundation.org/issues/1911