detect: Ensure app-layer decode events are logged #6709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves events for file decode and buffer count limits to a centralized location for easier handling. Issue: OISF#4482
This commit increases the duration of availability for packet pointer within the detect context. Issue: OISF#4482
This commit includes the packet decoder events. Issue: OISF#4482
This commit records the app-layer decode event for anomaly reporting. Issue: OISF#4482
Ticket: OISF#4898 This commit adds a brief description of tags used for events that occur during protocol layer decoding, e.g., SWF file handling.
Codecov Report
@@ Coverage Diff @@
## master #6709 +/- ##
==========================================
+ Coverage 77.12% 77.21% +0.08%
==========================================
Files 613 613
Lines 185666 185671 +5
==========================================
+ Hits 143194 143363 +169
+ Misses 42472 42308 -164
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Continued in #6710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6663
This PR ensures that app-layer decode events are logged when anomaly logging is enabled.
Link to redmine ticket: 4898
Describe changes:
suricata-verify-pr: 589
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: