Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/rules: Increase array size to remove SEGV #5435

Closed
wants to merge 3 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #5429

This commit changes the size of reporting variables to be dynamic based
on the buffer ids in use instead of a fixed value to address a SEGV when
the fixed value was less than the max buffer/type id in use.

Link to redmine ticket: 3904

Describe changes:

  • Corrects copy/paste error with include-mpm-stats conf variable.

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

This commit changes the size of reporting variables to be dynamic based
on the buffer ids in use instead of a fixed value to address a SEGV when
the fixed value was less than the max buffer/type id in use.
This commit corrects a copy/paste error handling the `include-mpm-stats`
configuration setting.
@victorjulien
Copy link
Member

Merged in #5464, thanks! I renamed the detect/clang commit as the clang part made no sense to me.

@jlucovsky jlucovsky deleted the 3904/3 branch October 5, 2020 13:17
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 4, 2022
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 4, 2022
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 4, 2022
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 4, 2022
As it is logged

Ticket: OISF#5435
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 26, 2022
As it is logged

Ticket: OISF#5435
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Aug 18, 2022
benignbala pushed a commit to benignbala/suricata that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants