http2: handles incomplete frames after banner #5392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To signal incomplete data, we must return the number of consumed bytes. When we get a banner and some records, we have to take into account the number of bytes already consumed by the banner parsing before reaching an incomplete record.
Closed
|
Merged in #5396, thanks! |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jun 13, 2022
Until now only the size of gaps counted in the regular append, not close and open. Bug: OISF#5392.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jun 13, 2022
Until now only the size of gaps counted in the regular append, not close and open. Bug: OISF#5392.
kgliveaction
pushed a commit
to liveaction/suricata
that referenced
this pull request
Jul 19, 2022
Until now only the size of gaps counted in the regular append, not close and open. Bug: OISF#5392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3917
Describe changes: