Http2 upgrade v8 #5390
Closed
Http2 upgrade v8 #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is NULL or the pointer to the previous state for the previous protocol in the case of a protocol change, for instance from HTTP1 to HTTP2 This way, the new protocol can use the old protocol context. For instance, HTTP2 mimicks the HTTP1 request, to have a HTTP2 transaction with both request and response
moved to suricata-verify
ie do not stop on first try if we do not have enough data
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
Closed
Closed
|
Merged in #5396, thanks! |
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3866
Describe changes:
-DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTIONPRScript output (if applicable):
suricata-verify-pr: 326
Makes OISF/suricata-verify#326 pass
Modifies #5380 by putting unit tests removal in its own commit
The downside compared to #5354 is to have one more test
FlowChangeProto(f)to run at (almost) each call ofAppLayerParserParse