-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect/asn1: Migrate to Rust - v1 #4954
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update der-parser crate and update kerberos and snmp modules with API changes
This module uses the `der-parser` crate to parse ASN1 objects in order to replace src/util-decode-asn1.c It also handles the parsing of the asn1 keyword rules and detection checks performed in src/detect-asn1.c
Mark rust extern "C" functions as pub in asn1 module to expose via cbindgen Update detect-asn1.c/h to use rust functions
- In favor of rust parser
- To be consistent with recent C version changes - Add checks for over/underflows
- Failure to parse asn1-max-frames - Failure on asn1 detection checks
- 'static is only realistic when allocating and leaking it over the FFI boundary
Blockers: CI: Rust 1.34.2 fails to compile der-parser and ipsec-parser Compiling der-parser v4.0.0-alpha3
error[E0658]: use of unstable library feature 'option_xor' (see issue #50512)
--> /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/der-parser-4.0.0-alpha3/src/ber/ber.rs:392:33
|
392 | if self.raw_tag.xor(other.raw_tag).is_none() {
| ^^^
Compiling ipsec-parser v0.5.0
error[E0658]: use of unstable library feature 'iter_copied' (see issue #57127)
--> /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/der-parser-4.0.0-alpha3/src/oid.rs:134:14
|
134 | .copied()
| ^^^^^^ |
cc @chifflier |
victorjulien
requested changes
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. Nice work!
Continued: #4965 |
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: Request for review/comments
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2977
Describe changes:
PRScript output (if applicable):
TODO:
rust/Cargo.toml.in