source/erf: validate record length before read - v1 #4783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the ERF record length before attempting to read it as a record length less than the size of the record header is invalid. Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3593
|
In general, do we have ERF tests? Does SV even support the format? |
No, and no. |
Closed
|
Merged in #4788, thanks Jason. |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 20, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 20, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 20, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 20, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 21, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 22, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 22, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 27, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 28, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 29, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 30, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jan 31, 2025
For registration of app-layer inspection, no longer use the 'needs' table from the script, but instead use the rule hook setting. Ticket: OISF#4783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the ERF record length before attempting to read it as
a record length less than the size of the record header
is invalid.
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3593
PRScript output (if applicable):