app-layer-ssl: fix memleak #1934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid that the SNI extension code is executed twice sometimes, causing memory leaks.
| @@ -65,6 +65,9 @@ SCEnumCharMap tls_decoder_event_table[ ] = { | |||
| { "INVALID_HEARTBEAT_MESSAGE", TLS_DECODER_EVENT_INVALID_HEARTBEAT }, | |||
| { "OVERFLOW_HEARTBEAT_MESSAGE", TLS_DECODER_EVENT_OVERFLOW_HEARTBEAT }, | |||
| { "DATALEAK_HEARTBEAT_MISMATCH", TLS_DECODER_EVENT_DATALEAK_HEARTBEAT_MISMATCH }, | |||
| { "MULTIPLE SNI EXTENSIONS", TLS_DECODER_EVENT_MULTIPLE_SNI_EXTENSIONS }, | |||
There was a problem hiding this comment.
These should not contain spaces but underscores. They are used as 'tls.multiple_sni_extensions' in the app-layer-events rule keyword.
There was a problem hiding this comment.
See https://github.com/inliniac/suricata/blob/master/rules/tls-events.rules for how they are used.
There was a problem hiding this comment.
Can you also add rules to rules/tls-events.rules for each of the new events?
There was a problem hiding this comment.
Note to self: coffee first, then pull requests :)
Thanks for the comments. I'll fix!
|
Replaced by #1935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid that the SNI extension code is executed multiple times on malformed packets, causing memory leaks.
https://redmine.openinfosecfoundation.org/issues/1736