pgsql: don't error out with PDU parsing errors - v1 #12543
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some backend messages can be the shortest pgsql length possible, 4 bytes, but the parser expectd all messages to be longer than that.
The initial parsing for message type checking was more complex than needed be. Related to Task OISF#5524
Even if unknown, if the message is properly parsed, allow the parser to proceed. Related to Task OISF#5524
This allows the app-proto to continue onto parsing next PDUs, if possible. Task OISF#5524
|
TODO: edit commit messages, since this isn't a task, but a bug-fix |
|
Information: QA ran without warnings. Pipeline 24669 |
|
Think this is looking good so far. Looking forward to the next round :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5524
This isn't fully ready yet, the different errors should lead to pgsql events.
I'd also like to better handle the length error handling, to be able to actually capture that when parsing requests or responses -- and set the right event.
Describe changes:
AppLayerResult::err()for parsing errors, to allow the parser to reach further messagesProvide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2276