analysis: report rule state altered by other rule - v3 #12515
+116
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For setting s->init_data for flowbit rules impacted by `set`, we can first check whether this will be needed, and *then* walk over the flowbits array.
Flowbits can make a rule such as a packet rule be treated as a stateful rule, without actually changing the rule type. Add a flag to allow reporting such cases via engine analysis. Task OISF#7456
This was referenced Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12515 +/- ##
==========================================
- Coverage 80.68% 80.68% -0.01%
==========================================
Files 925 925
Lines 258916 258993 +77
==========================================
+ Hits 208914 208976 +62
- Misses 50002 50017 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12311
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
analysis: report rule state altered by other rule -
Describe changes:
issetsids array if there are signatures that must be flagged as statefuldependencieswon't be presentOutput sample:
A rule with a flowbit dependency will have the
dependenciesobject. Otherwise, nothing is logged.{ "raw": "alert tcp-pkt any any -> any any (msg:\"Flowbit isset ored flowbits - pkt rule\"; flowbits:isset,fb5|fb6; sid:16;)", "id": 16, "gid": 1, "rev": 0, "msg": "Flowbit isset ored flowbits - pkt rule", "app_proto": "unknown", "requirements": [ "flow", "real_pkt" ], "type": "pkt", "dependencies": { "flowbits": { "upstream": { "state_modifying_rules": { "sids": [ 2, 15 ], "names": [ "fb6", "fb5" ] } } } } }Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2270