Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libhtp rs v27.2 small step for src #12509

Closed
wants to merge 4 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696

Describe changes:

  • prepare libhtp-rs by minimizing the diff for src subdir

This allow to go one small step further

#12474 next round

git diff libhtp-rs-v27 --name-only -- src/ gives

  • src/Makefile.am : remove libhtp.h 🟢
  • src/app-layer-htp-libhtp.c : removal 🟢
  • src/app-layer-htp-libhtp.h : removal 🟢
  • src/app-layer-htp.c : many changes as expected, and to be worked upon in a next PR 🚧
  • src/app-layer-htp.h : changes will remain until the final PR I think 🟢
  • src/detect-http-headers-stub.h : removal of libhtp.h 🟢
  • src/detect-http-host.c : I do not see a better migration path for parsed uri
  • src/detect-http-protocol.c : #ifdef removed 🟢
  • src/detect-http-uri.c : I do not see a better migration path for parsed uri
  • src/suricata.c : #ifdef removed and only one libhtp version 🟢
  • src/util-lua-http.c : I do not see a better migration path for parsed uri

In preparation of libhtp rust

Mainly adding some const
In preparation of libhtp rust

Mainly adding some const
In preparation of libhtp rust

Mainly adding some const
In preparation of libhtp rust
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 52.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (cfbf8fd) to head (1abee61).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12509      +/-   ##
==========================================
+ Coverage   80.56%   80.57%   +0.01%     
==========================================
  Files         925      925              
  Lines      259292   259282      -10     
==========================================
+ Hits       208906   208926      +20     
+ Misses      50386    50356      -30     
Flag Coverage Δ
fuzzcorpus 56.14% <17.64%> (-0.01%) ⬇️
livemode 19.39% <0.00%> (+<0.01%) ⬆️
pcap 44.23% <0.00%> (+0.03%) ⬆️
suricata-verify 63.39% <20.58%> (+<0.01%) ⬆️
unittests 58.44% <32.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Jan 30, 2025
@victorjulien
Copy link
Member

Merged in #12514, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants