next/698/20250123/v1 #12462
Merged
next/698/20250123/v1 #12462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of flowbit prefilter work that needs this info earlier. Track potential prefilter sm's to avoid unnecessary looping during setup.
Instead of C files requiring it. In preparation of libhtp rust, to minimize the final commit.
In preparation of libhtp rust This occurence was missed in 23050d7
For request and response headers In preparation of libhtp rust
In preparation of libhtp rust
ldap.request.operation matches on Lightweight Directory Access Protocol request operations This keyword maps to the eve field ldap.request.operation It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
ldap.responses.operation matches on Lightweight Directory Access Protocol response operations This keyword maps to the eve field ldap.responses[].operation It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
ldap.responses.count matches on the number of LDAP responses This keyword maps to the eve field len(ldap.responses[]) It is an unsigned 32-bit integer Doesn't support prefiltering Ticket: OISF#7453
make should rerun cbindgen if cbindgen.toml is modified
Just use a regular compile time rust export, instead of having a runtime definition through the SuricataContext structure
when compiling without unit tests detect-transform-base64.c:47:9: warning: macro is not used [-Wunused-macros] 47 | #define DETECT_TRANSFORM_FROM_BASE64_MODE_DEFAULT (uint8_t) Base64ModeRFC4648
Make all the hasher's have the same variants: - add hex digest for sha256 - add finalize to hex for sha1 - add hex digest for sha1
Expose md5, sha1, and sha256 to Lua scripts with
`require("suricata.hashing")`.
Ticket: 7073
Use a single array of built-ins and provide 2 functions for registering them: - SCLuaLoadBuiltIn: for loading built-in modules in sandboxed environments. - SCLuaRequirefBuiltIns: registers built-in modules with the standard package tool, allows built-ins to be loaded by output scripts that are not restricted I hope to refactor the sandbox so they can use SCLuaRequirefBuiltIns as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12462 +/- ##
==========================================
- Coverage 80.63% 80.52% -0.12%
==========================================
Files 920 923 +3
Lines 258739 259176 +437
==========================================
+ Hits 208643 208708 +65
- Misses 50096 50468 +372
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24338 |
catenacyber
approved these changes
Jan 24, 2025
|
Information: QA ran without warnings. Pipeline 24344 |
This was referenced Jan 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2253