ndpi: ndpi as a plugin - v5 #12423
Closed
ndpi: ndpi as a plugin - v5 #12423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Download and build nDPI - Enable nDPI during Suricata ./configure - Test that the plugin was built and installed
The format is left free-form, as its controled by a plugin.
By adding no_mangle to non-pub functions they enter the global name space and can conflict with other functions. In this case another sha library used by a plugin. Related ticket: https://redmine.openinfosecfoundation.org/issues/7498
The eve callback in ndpi requires a flow, so bail earlier if there is no flow.
Split DetectHelperKeywordRegister into 2 functions, one for acquiring a new keyword ID, and another to perform the registration. This makes it easier to do the traditional C keyword initialization with a dynamic ID.
jasonish
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12423 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 918 918
Lines 258696 258696
==========================================
- Hits 208598 208587 -11
- Misses 50098 50109 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24257 |
victorjulien
requested changes
Jan 18, 2025
| Suricata should be compiled with the nDPI support and the ``ndpi`` | ||
| plugin must be loaded before it can be used. | ||
|
|
||
| Example of configuring Suricata to be compiled with nDPI support: |
There was a problem hiding this comment.
would be good to mention the requires rule support here as well I think
| - Malware host contacted | ||
| - and many other... | ||
|
|
||
| Suricata should be compiled with the nDPI support and the ``ndpi`` |
|
Ping @cardigliano, can you take a look at these issues? I think the "integration" is more or less complete with this PR, just some code items to deal with in the implementation of the plugin. |
|
I fixed the issues in our branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12412
Changes:
Outstanding comment from previous PR: