applayer: incr flow counter if alproto for other dir was detected #12415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the pcap at hand, for example, on master, I see: |
Consider a case like the following. -> Opposing direction data comes in first -> At the beginning of Protocol Detection, the alproto for other side is unknown -> A successful call to TCPProtoDetectTriggerOpposingSide can however lead to detection of alproto for the other side -> Following this, a successful call is made to AppLayerParserParse However, the flow counter is not incremented for this case. This also does not map the number of flow events logged by Suricata for such a case. Increment the flow counter for a new flow for any applayer proto that is accepted by that specific protocol's parser. Related to Bug 7238
inashivb
force-pushed
the
flow-counter-update/v1
branch
from
3c14f81 to
3ba44a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12415 +/- ##
=======================================
Coverage 80.63% 80.64%
=======================================
Files 918 918
Lines 258696 258700 +4
=======================================
+ Hits 208598 208627 +29
+ Misses 50098 50073 -25
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7238
@catenacyber
What do you think about this?
Can this lead to additional flows being miscalculated for any cases?