ndpi: ndpi as a plugin - v3 #12410
Closed
ndpi: ndpi as a plugin - v3 #12410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Download and build nDPI - Enable nDPI during Suricata ./configure - Test that the plugin was built and installed
The format is left free-form, as its controled by a plugin.
By adding no_mangle to non-pub functions they enter the global name space and can conflict with other functions. In this case another sha library used by a plugin.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12410 +/- ##
==========================================
+ Coverage 80.63% 80.64% +0.01%
==========================================
Files 917 917
Lines 258687 258687
==========================================
+ Hits 208601 208631 +30
+ Misses 50086 50056 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24234 |
|
Back to draft, I thought I had the test fixed up. |
The eve callback in ndpi requires a flow, so bail earlier if there is no flow.
jasonish
force-pushed
the
ish/ndpi/plugin/v3
branch
from
94d6aa2 to
47eacf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #12120.
Changes:
I guess that last bit we be an S-V test, since we do plan on shipping this in our tree.